Quantcast
Channel: MobileRead Forums - Kobo Developer's Corner
Viewing all articles
Browse latest Browse all 1561

Glo bug in upgrade-wifi.sh?

$
0
0
Hello all,
I'm very new to the forum and to Kobo hacking.
While looking at /etc/init.d/upgrade-wifi.sh from 3.17.3 release, I discovered a possible bug. Look around lines 23~33:

if [ $CPU ]; then
PCB=`ntx_hwconfig -s -p /dev/mmcblk0 PCB`
RAM=`ntx_hwconfig -s -p /dev/mmcblk0 RAMType`
RAM_SIZE=`ntx_hwconfig -s -p /dev/mmcblk0 RamSize`
RAM_SIZE=`echo $RAM_SIZE | awk '{print $RAM_SIZE-MB}'`
NEW_UBOOT=/mnt/onboard/.kobo/upgrade/$PLATFORM/u-boot_mddr_$RAM_SIZE-$PCB-$RAM.bin
NEW_KERNEL=/mnt/onboard/.kobo/upgrade/$PLATFORM/uImage-$PCB
[ ! -e NEW_UBOOT ] && NEW_UBOOT=/mnt/onboard/.kobo/upgrade/$PLATFORM/u-boot_lpddr2_$RAM_SIZE-$PCB-$RAM.bin
UBOOT=$NEW_UBOOT
KERNEL=$NEW_KERNEL
fi

See the bolded line, shouldn't it read:

[ ! -e $NEW_UBOOT ] && NEW_UBOOT=/mnt/onboard/.kobo/upgrade/$PLATFORM/u-boot_lpddr2_$RAM_SIZE-$PCB-$RAM.bin

Am I wrong? Without the dollar, NEW_UBOOT variable is not expanded, the test fails and the variable NEW_UBOOT is always assigned the value /mnt/onboard/.kobo/upgrade/$PLATFORM/u-boot_lpddr2_$RAM_SIZE-$PCB-$RAM.bin.
As no u-boot_lpddr2* file exists in the package, the bootloader is never updated.
Any thoughts?
Cheers
- Lorenzo -

Viewing all articles
Browse latest Browse all 1561

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>